Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supported fioclex for ioctl on macos #4129

Closed
wants to merge 29 commits into from

Conversation

geetanshjuneja
Copy link
Contributor

Closes #4126

@RalfJung
Copy link
Member

RalfJung commented Jan 9, 2025

Thanks for the PR!

Please also add a test calling the function, as noted by @tiif. If you cannot make the test pass, that's fine, please still push it and then hopefully someone has the time to look at it and help. :)

@geetanshjuneja
Copy link
Contributor Author

@rustbot ready

@rustbot rustbot added the S-waiting-on-review Status: Waiting for a review to complete label Jan 9, 2025
src/shims/unix/fd.rs Outdated Show resolved Hide resolved
Copy link
Member

@RalfJung RalfJung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks! I only have minor comments.

src/helpers.rs Outdated Show resolved Hide resolved
src/shims/unix/fd.rs Outdated Show resolved Hide resolved
src/shims/unix/fd.rs Outdated Show resolved Hide resolved
src/shims/unix/fd.rs Outdated Show resolved Hide resolved
tests/pass-dep/libc/libc-fs.rs Outdated Show resolved Hide resolved
tests/pass-dep/libc/libc-fs.rs Outdated Show resolved Hide resolved
tests/pass-dep/libc/libc-fs.rs Outdated Show resolved Hide resolved
@RalfJung
Copy link
Member

@rustbot author
Please post @rustbot ready when the PR is ready for the next round of review.

@rustbot rustbot added S-waiting-on-author Status: Waiting for the PR author to address review comments and removed S-waiting-on-review Status: Waiting for a review to complete labels Jan 11, 2025
@RalfJung
Copy link
Member

That should do it, thanks!

Please squash the commits. (Keep the new pipe test a separate commit if you can, but it's not a big deal to have that squashed as well.)

@rustbot
Copy link
Collaborator

rustbot commented Jan 11, 2025

There are merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged.

You can start a rebase with the following commands:

$ # rebase
$ git pull --rebase https://github.com/rust-lang/miri.git master
$ git push --force-with-lease

The following commits are merge commits:

@rustbot
Copy link
Collaborator

rustbot commented Jan 11, 2025

There are merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged.

You can start a rebase with the following commands:

$ # rebase
$ git pull --rebase https://github.com/rust-lang/miri.git master
$ git push --force-with-lease

The following commits are merge commits (since this message was last posted):

@geetanshjuneja geetanshjuneja deleted the ioctl branch January 16, 2025 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: Waiting for the PR author to address review comments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support FIOCLEX for ioctl in macos
6 participants