-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supported fioclex for ioctl on macos #4129
Conversation
Thanks for the PR! Please also add a test calling the function, as noted by @tiif. If you cannot make the test pass, that's fine, please still push it and then hopefully someone has the time to look at it and help. :) |
@rustbot ready |
…e-changes Switched FreeBSD to pthread_setname_np
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks! I only have minor comments.
@rustbot author |
That should do it, thanks! Please squash the commits. (Keep the new pipe test a separate commit if you can, but it's not a big deal to have that squashed as well.) |
There are merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged. You can start a rebase with the following commands:
The following commits are merge commits: |
There are merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged. You can start a rebase with the following commands:
The following commits are merge commits (since this message was last posted): |
Closes #4126